Skip to content

🐛 Handles socketio exception on disconnect and fixes double logging of monitoring middleware #8067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 9, 2025
Merged

🐛 Handles socketio exception on disconnect and fixes double logging of monitoring middleware #8067

merged 11 commits into from
Jul 9, 2025

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 7, 2025 •
edited
Loading

What do these changes do?

Following up https://github.com/ITISFoundation/private-issues/issues/212, we monitored issues in the logs and here we provides some fixes

  1. socketio._handlers.disconnect: Unhandled exception on disconnect handled for socketio. Here session was already cleared before
    image
  2. monitoring middleware duplicates every log since it the errors_middleware already handles them. Removing logs from it e.g.
    image
  3. aiohttp.web_exceptions.HTTPCreated: Created logged error is already resolved in 🐛♻️ webserver error handling: Fix incorrect error logging for web.HTTPCreated; cleanup success response handling #7952

Related issue/s

in place

How to test

Dev-ops

None

@pcrespov pcrespov added this to the Engage milestone Jul 7, 2025
@pcrespov pcrespov self-assigned this Jul 7, 2025
@codecov
Copy link

codecov bot commented Jul 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.21%. Comparing base (0480725) to head (5864be1).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8067      +/-   ##
==========================================
- Coverage   88.30%   88.21%   -0.10%     
==========================================
  Files        1856     1435     -421     
  Lines       71790    59590   -12200     
  Branches     1262      626     -636     
==========================================
- Hits        63394    52565   -10829     
+ Misses       8031     6816    -1215     
+ Partials      365      209     -156
Flag Coverage Δ
integrationtests 64.22% <64.70%> (-0.02%) ⬇️
unittests 86.54% <60.00%> (-0.37%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 71.37% <33.33%> (+0.12%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.05% <ø> (ø)
agent 96.29% <ø> (ø)
api_server 92.83% <ø> (ø)
autoscaling 95.88% <ø> (ø)
catalog 92.58% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.79% <ø> (-0.57%) ⬇️
datcore_adapter 97.94% <ø> (ø)
director 76.77% <ø> (ø)
director_v2 91.01% <ø> (-0.02%) ⬇️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.60% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 92.15% <ø> (-0.43%) ⬇️
storage 86.64% <ø> (+0.04%) ⬆️
webclient ∅ <ø> (∅)
webserver 88.60% <64.70%> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0480725...5864be1. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov changed the title WIP: Mai/follow up cns 2025 🐛 Handles socketio exception on disconnect and fixes double logging of monitoring middleware Jul 7, 2025
@pcrespov pcrespov added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work labels Jul 7, 2025
@pcrespov pcrespov marked this pull request as ready for review July 7, 2025 16:51
@pcrespov pcrespov enabled auto-merge (squash) July 7, 2025 16:52
@pcrespov
Copy link
Member Author

pcrespov commented Jul 7, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • any of: [🛡 GitHub branch protection]
        • check-neutral = deploy to dockerhub
        • check-skipped = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-neutral = unit-tests
        • check-skipped = unit-tests
        • check-success = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-neutral = integration-tests
        • check-skipped = integration-tests
        • check-success = integration-tests

@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 7, 2025
sanderegg
sanderegg approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

giancarloromeo
giancarloromeo approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️

matusdrobuliak66
matusdrobuliak66 approved these changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #8067 has been dequeued. The pull request rule doesn't match anymore.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

GitHK
GitHK approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few questions

@pcrespov
Copy link
Member Author

pcrespov commented Jul 8, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests

@mergify
Copy link
Contributor

mergify bot commented Jul 9, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@pcrespov pcrespov disabled auto-merge July 9, 2025 12:11
@pcrespov pcrespov merged commit 9e46844 into ITISFoundation:master Jul 9, 2025
3 of 4 checks passed
@pcrespov pcrespov deleted the mai/follow-up-cns-2025 branch July 9, 2025 12:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@pcrespov pcrespov

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:services-library issues on packages/service-libs a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

5 participants

@pcrespov @giancarloromeo @GitHK @sanderegg @matusdrobuliak66